Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update to Fedora 40 #540

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Dockerfile: update to Fedora 40 #540

merged 1 commit into from
Jun 18, 2024

Conversation

aaradhak
Copy link
Member

@aaradhak
Copy link
Member Author

@jlebon I see that the release notes are already updated to Fedora 40 in this case - https://github.com/coreos/butane/blob/main/docs/release-notes.md

@aaradhak aaradhak requested a review from jlebon June 12, 2024 21:09
@jlebon
Copy link
Member

jlebon commented Jun 12, 2024

@jlebon I see that the release notes are already updated to Fedora 40 in this case - main/docs/release-notes.md

Not quite. That release note entry refers to the butane binary. The container image itself being based on Fedora 40 is a separate change. Though it doesn't look like historically we've release noted it.

That said, this is missing another instance in the same file.

Dockerfile Show resolved Hide resolved
@prestist
Copy link
Collaborator

@aaradhak after you have updated both From's you can then add a label for "skip notes" as we dont generally doc the update of this.

@aaradhak aaradhak added the skip-notes This PR does not need release notes label Jun 14, 2024
@aaradhak aaradhak enabled auto-merge June 14, 2024 21:20
@aaradhak aaradhak requested a review from prestist June 14, 2024 21:20
@aaradhak aaradhak merged commit d26d803 into coreos:main Jun 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-notes This PR does not need release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants